test pr #2
Closed
test pr #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkDaoust
force-pushed
the
test-test
branch
7 times, most recently
from
5e7fb1b to
9c2a7b1
Compare
MarkDaoust
added a commit
that referenced
this pull request
May 3, 2024
* Add metaclass to inject Permission methods Set PermissionAdapterMeta as a metaclass for Corpus and TunedModel classes to inject permission methods dynamically. * Add method to validate permission name * Allow accepting partial name for get_permission methods * Fix consistency issues * Update tests * Remove metaclasses and use inheritance instead * format * Update tests and fix pytpye error * Update tests * disable attribute error for PermissionsAdapter - pytpye for `self.name` field * Format * Handle partial names in get_permissions methods * Update tests * Update docsting for get_permission method * format * Add guard against invalid full name formats * Update tests * format * Update Valid Permission Name regex * Separate resource name validation for get_permission methods * Make o_proto method internal for Permission class o_proto to _to_proto and update invlaid error message for permission_id. * Update error messages * started editing the permissions class Change-Id: Idf1b9e8b0fff498a1c4fd4785c09eb49963c1d47 * Fix tests Change-Id: Id8cc1cf6e59009f06e8db3ff59edd7ef6ac76943 * Add type hints. Change-Id: I91f759fe3ebe4e3011440a3983a4cbfc317856d0 * Fix transfer_ownership for Corpora Change-Id: I791514660881ce967c405e4c76f44739968362f9 * format Change-Id: I0f98fc80fe81a8fc69aea9f00386aa2c519cb7e0 * Simplify error msgs * Simplify name checks * Add deprecation stubs on Corpus * Fix decorator type checking ast.Call.func can be of types ast.Attribute and ast.Name, previously only ast.Name was being considered. * fix types * fix types (#2) * Update retriever_types.py * Update retriever_types.py --------- Co-authored-by: Mark Daoust <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.