Skip to content

Conversation

@xiaoyuanzi1230
Copy link
Contributor

As working with multiple customers about below user scenario:

Synapse workspace integrates with Git repo, and public network access is disabled.

Under this situation, we found user can still access to the workspace, it "bypass" the network setting due to studio directly calls Git api. And user can commit, create pull request, create branch and delete branch (all operations that relates to Git), but cannot publish changes to synapse live mode (due to block by firewall as sending request to synapse dev endpoint).

As discussed with Synapse Studio PM, currently this is by design and need to have this important note in the public doc. So request this commit to merge the important notes.

As working with multiple customers about below user scenario:

Synapse workspace integrates with Git repo, and public network access is disabled.

Under this situation, we found user can still access to the workspace, it "bypass" the network setting due to studio directly calls Git api. And user can commit, create pull request, create branch and delete branch, but cannot publish changes to synapse live mode.

As discussed with Synapse Studio PM, currently this is by design and need to have this important notes in the public doc. So request this commit to merge the important notes.
@prmerger-automator
Copy link
Contributor

@xiaoyuanzi1230 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit f90ae14:

✅ Validation status: passed

File Status Preview URL Details
articles/synapse-analytics/security/connectivity-settings.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ShannonLeavitt
Copy link
Contributor

@Danzhang-msft

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Oct 24, 2023
Copy link
Contributor

@Danzhang-msft Danzhang-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest change to:

When the public network access is disabled, access to GIT mode in Synapse Studio and commit changes will not be blocked as long as the user has enough permission to access the integrated Git repo or the corresponding Git branch. But the publish button will not work as the access to Live mode is blocked by the firewall settings.

@Court72
Copy link
Contributor

Court72 commented Oct 27, 2023

@xiaoyuanzi1230 - Can you respond to the requested changes or let us know if you would like us to commit them?

@Danzhang-msft - After the changes are made, please add a sign-off command to signal that the PR is ready to merge.

@xiaoyuanzi1230
Copy link
Contributor Author

Hello @Court72 I am good for the suggested changes. I believe we can commit the change. Thanks

And @Danzhang-msft Thanks a lot for the suggestion!

@Court72
Copy link
Contributor

Court72 commented Oct 30, 2023

@Danzhang-msft,

I committed your suggestions.

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 189c3a8:

✅ Validation status: passed

File Status Preview URL Details
articles/synapse-analytics/security/connectivity-settings.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Danzhang-msft
Copy link
Contributor

#sign-off

@American-Dipper American-Dipper merged commit 36a2ef3 into MicrosoftDocs:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants