-
Notifications
You must be signed in to change notification settings - Fork 21.9k
Update connectivity-settings.md #116378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update connectivity-settings.md #116378
Conversation
As working with multiple customers about below user scenario: Synapse workspace integrates with Git repo, and public network access is disabled. Under this situation, we found user can still access to the workspace, it "bypass" the network setting due to studio directly calls Git api. And user can commit, create pull request, create branch and delete branch, but cannot publish changes to synapse live mode. As discussed with Synapse Studio PM, currently this is by design and need to have this important notes in the public doc. So request this commit to merge the important notes.
|
@xiaoyuanzi1230 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit f90ae14: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
IMPORTANT: When the changes are ready for publication, add a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest change to:
When the public network access is disabled, access to GIT mode in Synapse Studio and commit changes will not be blocked as long as the user has enough permission to access the integrated Git repo or the corresponding Git branch. But the publish button will not work as the access to Live mode is blocked by the firewall settings.
|
@xiaoyuanzi1230 - Can you respond to the requested changes or let us know if you would like us to commit them? @Danzhang-msft - After the changes are made, please add a sign-off command to signal that the PR is ready to merge. |
|
Hello @Court72 I am good for the suggested changes. I believe we can commit the change. Thanks And @Danzhang-msft Thanks a lot for the suggestion! |
|
I committed your suggestions. When the changes are ready for publication, add a |
|
Learn Build status updates of commit 189c3a8: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
#sign-off |
As working with multiple customers about below user scenario:
Synapse workspace integrates with Git repo, and public network access is disabled.
Under this situation, we found user can still access to the workspace, it "bypass" the network setting due to studio directly calls Git api. And user can commit, create pull request, create branch and delete branch (all operations that relates to Git), but cannot publish changes to synapse live mode (due to block by firewall as sending request to synapse dev endpoint).
As discussed with Synapse Studio PM, currently this is by design and need to have this important note in the public doc. So request this commit to merge the important notes.