Skip to content

Conversation

@rapopescu16
Copy link
Contributor

No description provided.

@prmerger-automator
Copy link
Contributor

@rapopescu16 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 69ca235:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-functions/functions-networking-options.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@v-dirichards
Copy link
Contributor

@ggailey777

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Feb 24, 2025
* The app and the virtual network must be in the same region.
* The feature requires an unused subnet that's a /28 or larger in an Azure Resource Manager virtual network.
* The integration subnet can be used by only one App Service plan.
* The feature requires a subnet that's a /28 or larger in an Azure Resource Manager virtual network.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rapopescu16 @im-samz - if the subnet is being used by other services (like a private endpoint into, say, service bus or storage) then the virtual network integration would fail. While I understand that the subnet can be shared between multiple app service plans now, it can't also be delegated to other services right? I think this distinction would still be worth calling out. For Flex Consumption in the docs we made this distinction by using two different bullet points:
image

Copy link
Contributor

@im-samz im-samz May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed this in a separate PR wtih Glenn: https://github.com/MicrosoftDocs/azure-docs-pr/pull/299657/files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@im-samz Should we close this PR if it was addressed in the private repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @v-dirichards, this comment was specifically for Thiago's suggestion. The changes raised in Raluca's PR were not part of that other PR.

@v-dirichards
Copy link
Contributor

@ggailey777 Could you review this proposed update to your article and enter #sign-off in a comment if it's ready to merge?

Thanks!

@v-dirichards
Copy link
Contributor

@ggailey777

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

1 similar comment
@v-dirichards
Copy link
Contributor

@ggailey777

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates documentation for Azure Functions networking options to reflect current capabilities around virtual network integration subnets.

  • Removed the requirement for subnets to be "unused"
  • Updated documentation to indicate that integration subnets can now be shared across multiple App Service plans

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants