- 
                Notifications
    
You must be signed in to change notification settings  - Fork 21.8k
 
Update functions-networking-options.md #125901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| 
           @rapopescu16 : Thanks for your contribution! The author(s) have been notified to review your proposed change.  | 
    
| 
           Learn Build status updates of commit 69ca235: ✅ Validation status: passed
 For more details, please refer to the build report. For any questions, please: 
  | 
    
| 
          
 Can you review the proposed changes? Important: When the changes are ready for publication, adding a  #label:"aq-pr-triaged"  | 
    
| * The app and the virtual network must be in the same region. | ||
| * The feature requires an unused subnet that's a /28 or larger in an Azure Resource Manager virtual network. | ||
| * The integration subnet can be used by only one App Service plan. | ||
| * The feature requires a subnet that's a /28 or larger in an Azure Resource Manager virtual network. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rapopescu16 @im-samz - if the subnet is being used by other services (like a private endpoint into, say, service bus or storage) then the virtual network integration would fail. While I understand that the subnet can be shared between multiple app service plans now, it can't also be delegated to other services right? I think this distinction would still be worth calling out. For Flex Consumption in the docs we made this distinction by using two different bullet points:

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I addressed this in a separate PR wtih Glenn: https://github.com/MicrosoftDocs/azure-docs-pr/pull/299657/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@im-samz Should we close this PR if it was addressed in the private repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @v-dirichards, this comment was specifically for Thiago's suggestion. The changes raised in Raluca's PR were not part of that other PR.
| 
           @ggailey777  Could you review this proposed update to your article and enter  Thanks!  | 
    
| 
          
 Can you review this old PR and determine whether it needs to be closed or merged? @MicrosoftDocs/public-repo-pr-review-team  | 
    
    
      
        1 similar comment
      
    
  
    | 
          
 Can you review this old PR and determine whether it needs to be closed or merged? @MicrosoftDocs/public-repo-pr-review-team  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates documentation for Azure Functions networking options to reflect current capabilities around virtual network integration subnets.
- Removed the requirement for subnets to be "unused"
 - Updated documentation to indicate that integration subnets can now be shared across multiple App Service plans
 
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.