Skip to content

Conversation

@kegregoi
Copy link
Contributor

@kegregoi kegregoi commented Jun 5, 2025

I changed this back to what is used to show. Using an object to hold the parameters for a basic test-netconnection command is really not needed and makes this look more complex than it really is

@prmerger-automator
Copy link
Contributor

@kegregoi : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@asudbring
Copy link
Contributor

Hello @kegregoi
Thank you for the dedication to our documentation. We use splatting in our commands for readability. There is no need for this change.

#please-close

@kegregoi
Copy link
Contributor Author

kegregoi commented Jun 5, 2025

@asudbring readability is the entire reason I made this. How is this:

$Params = @{
  ComputerName = "168.63.129.16"
  Port         = 80
}
Test-NetConnection @Params

$Params.Port = 32526
Test-NetConnection @Params

More readable than this:

Test-NetConnection -ComputerName 168.63.129.16 -Port 80

Test-NetConnection -ComputerName 168.63.129.16 -Port 32526

What I changed it to is much more readable and its just how people use this command

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 7463318:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-network/what-is-ip-address-168-63-129-16.md ✅Succeeded

For more details, please refer to the build report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants