Skip to content

Conversation

@jubu1812
Copy link

@jubu1812 jubu1812 commented Jul 6, 2025

Corrected JSON attribute names to start with uppercase letters in the 'Parameterizing the filter conditions for source partitioning' section, as lowercase attributes were not working.

Corrected JSON attribute names to start with uppercase letters in the 'Parameterizing the filter conditions for source partitioning' section, as lowercase attributes were not working.
@jubu1812
Copy link
Author

jubu1812 commented Jul 6, 2025

@microsoft-github-policy-service agree

@prmerger-automator
Copy link
Contributor

@jubu1812 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 7b782a6:

✅ Validation status: passed

File Status Preview URL Details
articles/data-factory/sap-change-data-capture-advanced-topics.md ✅Succeeded

For more details, please refer to the build report.

@v-dirichards
Copy link
Contributor

@ukchrist

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jul 7, 2025
@v-dirichards
Copy link
Contributor

@ukchrist Could you review this proposed update to your article and enter #sign-off in a comment if it's ready to merge?

Thanks!

@v-dirichards
Copy link
Contributor

v-dirichards commented Aug 4, 2025

@ukchrist

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

@v-dirichards
Copy link
Contributor

I sent a Teams message to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

@v-ccolin
Copy link
Contributor

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

@v-dirichards v-dirichards requested a review from Copilot October 1, 2025 21:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the JSON attribute names in the SAP Change Data Capture documentation from lowercase to uppercase format to ensure proper functionality. The changes address a technical issue where lowercase attribute names were not working correctly in the filter condition parameterization.

  • Updated JSON schema format from lowercase to uppercase for all filter condition attributes
  • Fixed attribute naming in code examples throughout the documentation
  • Ensured consistency across all JSON examples in the parameterization section

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants