Skip to content

Conversation

@rvrama
Copy link

@rvrama rvrama commented Sep 28, 2025

Made changes in 2 places for React Vite users to use dist folder instead of build. While building and while running with swa command locally. PLEASE IGNORE MY PREVIOUS COMMIT as this has complete change.

Made changes in 2 places for React Vite users to use dist folder instead of build.  While building and while running with swa command locally.
@prmerger-automator
Copy link
Contributor

@rvrama : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit b1e877a:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/static-web-apps/add-api.md ⚠️Warning Details

articles/static-web-apps/add-api.md

  • Line 260, Column 1: [Warning: invalid-tab-group - See documentation] Tab group with different tab id set.
  • Line 307, Column 5: [Warning: invalid-tab-group - See documentation] Tab group with different tab id set.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@ttorble ttorble requested a review from Copilot September 29, 2025 14:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the documentation for adding APIs to Static Web Apps to include specific instructions for React Vite users, who use the dist folder instead of the build folder for their build output.

  • Adds a new tab section for React (Vite) with proper build command and folder references
  • Updates both the build instructions and local development commands to accommodate Vite's dist output folder

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ttorble
Copy link
Contributor

ttorble commented Sep 29, 2025

@v1212

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Sep 29, 2025
@v-dirichards
Copy link
Contributor

@v1212

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit fc4d4ff:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/static-web-apps/add-api.md ⚠️Warning Details

articles/static-web-apps/add-api.md

  • Line 260, Column 1: [Warning: invalid-tab-group - See documentation] Tab group with different tab id set.
  • Line 307, Column 5: [Warning: invalid-tab-group - See documentation] Tab group with different tab id set.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@v-dirichards
Copy link
Contributor

v-dirichards commented Nov 7, 2025

@rvrama @cjk7989

The warnings must be fixed before this PR is ready to merge.

Once the warnings are clear, the commits must be moved to the private repository for automated checks and publishing. After you move the commits, close this PR (#please-close). If you need help moving the commits, contact the publicprs alias.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@v-dirichards v-dirichards reopened this Nov 7, 2025
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit fc4d4ff:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/static-web-apps/add-api.md ⚠️Warning Details

articles/static-web-apps/add-api.md

  • Line 260, Column 1: [Warning: invalid-tab-group - See documentation] Tab group with different tab id set.
  • Line 307, Column 5: [Warning: invalid-tab-group - See documentation] Tab group with different tab id set.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants