Skip to content

Conversation

@sophiatev
Copy link

There is potentially misleading behavior when calling continue-as-new in a finally block. If the orchestration encounters an uncaught exception during execution and enters a "failed" state, then the orchestration just completes rather than restarting. This is true even if the continue-as-new call occurs in a finally block, which is potentially misleading for customers (see this GitHub issue and this issue). This PR updates the documentation to include a note about this.

@prmerger-automator
Copy link
Contributor

@sophiatev : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit faf8b36:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-functions/durable/durable-functions-eternal-orchestrations.md ✅Succeeded

For more details, please refer to the build report.

@v-dirichards v-dirichards requested a review from Copilot October 28, 2025 15:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Durable Functions eternal orchestrations documentation to clarify behavior when orchestrations fail. Specifically, it adds a warning that continue-as-new calls in finally blocks will not restart an orchestration if it has entered a failed state due to an uncaught exception.

Key Changes:

  • Adds a new NOTE section explaining the failed orchestration behavior with continue-as-new
  • Clarifies that uncaught exceptions cause orchestrations to complete rather than restart, even when continue-as-new is in a finally block

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@v-dirichards
Copy link
Contributor

@cgillum

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Oct 28, 2025
Copy link
Contributor

@lilyjma lilyjma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small suggestion

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 36bbb02:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 36bbb02:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-functions/durable/durable-functions-eternal-orchestrations.md ✅Succeeded

For more details, please refer to the build report.

@lilyjma
Copy link
Contributor

lilyjma commented Oct 30, 2025

#sign-off

@prmerger-automator
Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @cgillum

@v-dirichards
Copy link
Contributor

Hi @lilyjma - Thanks for your review. In the public repo, pull requests should be signed off by the author, another member of the content team, or a PM.


@cgillum Could you take a look? Thanks!

@sophiatev
Copy link
Author

#sign-off

@prmerger-automator
Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @cgillum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants