- 
                Notifications
    You must be signed in to change notification settings 
- Fork 21.9k
Update the Eternal Orchestration Docs for Failed Orchestrations #127790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update the Eternal Orchestration Docs for Failed Orchestrations #127790
Conversation
| @sophiatev : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. | 
| Learn Build status updates of commit faf8b36: ✅ Validation status: passed
 For more details, please refer to the build report. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Durable Functions eternal orchestrations documentation to clarify behavior when orchestrations fail. Specifically, it adds a warning that continue-as-new calls in finally blocks will not restart an orchestration if it has entered a failed state due to an uncaught exception.
Key Changes:
- Adds a new NOTE section explaining the failed orchestration behavior with continue-as-new
- Clarifies that uncaught exceptions cause orchestrations to complete rather than restart, even when continue-as-newis in afinallyblock
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Can you review the proposed changes? Important: When the changes are ready for publication, adding a  #label:"aq-pr-triaged" | 
        
          
                articles/azure-functions/durable/durable-functions-eternal-orchestrations.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small suggestion
…hestrations.md Co-authored-by: lilyjma <[email protected]>
| Learn Build status updates of commit 36bbb02: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. | 
| Learn Build status updates of commit 36bbb02: ✅ Validation status: passed
 For more details, please refer to the build report. | 
| #sign-off | 
| Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @cgillum | 
| #sign-off | 
| Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @cgillum | 
There is potentially misleading behavior when calling
continue-as-newin a finally block. If the orchestration encounters an uncaught exception during execution and enters a "failed" state, then the orchestration just completes rather than restarting. This is true even if thecontinue-as-newcall occurs in afinallyblock, which is potentially misleading for customers (see this GitHub issue and this issue). This PR updates the documentation to include a note about this.