Skip to content

Update add-clustervirtualmachinerole.md #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 1, 2019

Conversation

DanieleDeAn
Copy link
Contributor

I have found an issue related to this Cmdlet in a large enterprise, we can add a note and maybe the link of the blog to explain better.

@o0nj
Copy link
Contributor

o0nj commented Jul 23, 2019

@DanieleDeAn Thank you for the valuable find. The PR is being rolled into review. Much appreciated.

@o0nj
Copy link
Contributor

o0nj commented Jul 23, 2019

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@o0nj
Copy link
Contributor

o0nj commented Jul 23, 2019

@dariomws306 @get-itips @tseward

Peer review needed for this PR. Thanks.

@dariomws
Copy link
Contributor

Looks ok, but I think we can improve it. Maybe two different notes?

Note: This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer.
Note: This cmdlet generate a .TMP file under the user temp folder, and you can't have more than 65535 .TMP files generated by this cmdlet, otherwise you will receive an exception "The File Exist". For more information, please go to:
https://techcommunity.microsoft.com/t5/ITOps-Talk-Blog/TQA-Add-ClusterVirtualMachineRole-fails-with-the-error-quot-The/ba-p/713344

What do you think?

@get-itips
Copy link
Contributor

Agree with @dariomws306

@@ -37,7 +37,12 @@ By creating clustered virtual machines, you can consolidate multiple servers on
Instead, if that server, or cluster node, fails or requires scheduled maintenance, then another node begins to run the virtual machines instead through a process known as failover.
The virtual hard disk (VHD) file for the clustered virtual machine must be on the clustered disk used by that virtual machine.

Note: This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer.

> **Note:** This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer. Also this cmdlet generate a .TMP file under the user temp folder, and you can't have more than 65535 .TMP files generated by this cmdlet otherwise you will receive an exception "The File Exist".
Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 Jul 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> **Note:** This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer. Also this cmdlet generate a .TMP file under the user temp folder, and you can't have more than 65535 .TMP files generated by this cmdlet otherwise you will receive an exception "The File Exist".
> [!Note]
> This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer.
> [!Note]
> This cmdlet generates a .TMP file under the user temp folder, and you can't have more than 65535 .TMP files generated by this cmdlet, otherwise you will receive an exception "The File Exist". For more information, please go to: https://techcommunity.microsoft.com/t5/ITOps-Talk-Blog/TQA-Add-ClusterVirtualMachineRole-fails-with-the-error-quot-The/ba-p/713344

Copy link
Contributor

@nenonix nenonix Jul 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> **Note:** This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer. Also this cmdlet generate a .TMP file under the user temp folder, and you can't have more than 65535 .TMP files generated by this cmdlet otherwise you will receive an exception "The File Exist".
> [!NOTE}
> This cmdlet generate a .TMP file in the user temp folder, and if more than 65535 .TMP files are generated you will get the error: "The File Exists". For more information, see this [support article](https://techcommunity.microsoft.com/t5/ITOps-Talk-Blog/TQA-Add-ClusterVirtualMachineRole-fails-with-the-error-quot-The/ba-p/713344).

Note: This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer.

> **Note:** This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer. Also this cmdlet generate a .TMP file under the user temp folder, and you can't have more than 65535 .TMP files generated by this cmdlet otherwise you will receive an exception "The File Exist".
https://techcommunity.microsoft.com/t5/ITOps-Talk-Blog/TQA-Add-ClusterVirtualMachineRole-fails-with-the-error-quot-The/ba-p/713344
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
https://techcommunity.microsoft.com/t5/ITOps-Talk-Blog/TQA-Add-ClusterVirtualMachineRole-fails-with-the-error-quot-The/ba-p/713344

Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy Review - Two notes in accordance with Dario's suggestion.


> **Note:** This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer. Also this cmdlet generate a .TMP file under the user temp folder, and you can't have more than 65535 .TMP files generated by this cmdlet otherwise you will receive an exception "The File Exist".
https://techcommunity.microsoft.com/t5/ITOps-Talk-Blog/TQA-Add-ClusterVirtualMachineRole-fails-with-the-error-quot-The/ba-p/713344

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

> **Note:** This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer. Also this cmdlet generate a .TMP file under the user temp folder, and you can't have more than 65535 .TMP files generated by this cmdlet otherwise you will receive an exception "The File Exist".
https://techcommunity.microsoft.com/t5/ITOps-Talk-Blog/TQA-Add-ClusterVirtualMachineRole-fails-with-the-error-quot-The/ba-p/713344


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -37,7 +37,12 @@ By creating clustered virtual machines, you can consolidate multiple servers on
Instead, if that server, or cluster node, fails or requires scheduled maintenance, then another node begins to run the virtual machines instead through a process known as failover.
The virtual hard disk (VHD) file for the clustered virtual machine must be on the clustered disk used by that virtual machine.

Note: This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Contributor

@nenonix nenonix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra lines

@dariomws
Copy link
Contributor

Also, I think the same note should be added to W2012 and 2012 R2 versions.

Copy link
Contributor Author

@DanieleDeAn DanieleDeAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JohanFreelancer9 i like the two notes, but why you are using the syntax "[!Note]"?
in the preview this syntax "**Note:**" bold text and create a better effect in my honest opinion.

Note:
This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer.

Note:
This cmdlet generates a .TMP file under the user temp folder, and you can't have more than 65535 .TMP files generated by this cmdlet, otherwise you will receive an exception "The File Exist". For more information, please go to: https://techcommunity.microsoft.com/t5/ITOps-Talk-Blog/TQA-Add-ClusterVirtualMachineRole-fails-with-the-error-quot-The/ba-p/713344

@ghost
Copy link

ghost commented Jul 25, 2019

[!NOTE] stands out in documentation and is the standard for adding NOTES. See https://docs.microsoft.com/en-us/sharepoint/upgrade-and-update/install-a-software-update as one example near the top in the purple-ish section of a note.

@DanieleDeAn
Copy link
Contributor Author

[!NOTE] stands out in documentation and is the standard for adding NOTES. See https://docs.microsoft.com/en-us/sharepoint/upgrade-and-update/install-a-software-update as one example near the top in the purple-ish section of a note.

Hi @tseward many thanks for the info, now is clear, but is also clear that the preview do not read correctly "[!NOTE]" syntax, or may be I wrong something :). Many thanks

@DanieleDeAn DanieleDeAn reopened this Jul 25, 2019
@DanieleDeAn
Copy link
Contributor Author

@JohanFreelancer9, @nenonix Hi, I have modified the file based on your suggestion but probably I need to study more Github! :) because now i see that your info are outdated, sorry guys but this is a new world for me :), If I need to change something please let me know ;)

@@ -37,7 +37,11 @@ By creating clustered virtual machines, you can consolidate multiple servers on
Instead, if that server, or cluster node, fails or requires scheduled maintenance, then another node begins to run the virtual machines instead through a process known as failover.
The virtual hard disk (VHD) file for the clustered virtual machine must be on the clustered disk used by that virtual machine.

Note: This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer.

> [!NOTE]This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> [!NOTE]This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer.
> [!NOTE] This cmdlet cannot be run remotely without Credential Security Service Provider (CredSSP) authentication on the server computer.

Many thanks Johan

Co-Authored-By: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy Review - Please insert spaces as indicated.

@DanieleDeAn
Copy link
Contributor Author

Copy Review - Please insert spaces as indicated.

Done and many tnx ;)

@DanieleDeAn
Copy link
Contributor Author

Hi @e0i we have a version ready to be merged in the master branch, I need to do something? :)
Many Thanks :)

@o0nj
Copy link
Contributor

o0nj commented Jul 30, 2019

Hello @DanieleDeAn, It seems that the notes need to be added for other supported Windows versions, via dariomws306's comment below,

Also, I think the same note should be added to W2012 and 2012 R2 versions.

The corresponding folders for these two Windows versions can be found under winserver2012-ps winserver2012r2-ps directories.

Thank you.

Modified the File for 2012 and 2012R2
@msftclas
Copy link

msftclas commented Jul 31, 2019

CLA assistant check
All CLA requirements met.

@DanieleDeAn
Copy link
Contributor Author

Hi @e0i, you are correct ! I miss this info , I have modified also the version for 2012 and 2012R2, and many thanks to @dariomws306 ;).
Cheers!

@o0nj
Copy link
Contributor

o0nj commented Aug 1, 2019

@DanieleDeAn Thank you for your valuable contributions and taking the time to follow-up with reviewer's suggestions. The PR will now be merged.

@o0nj
Copy link
Contributor

o0nj commented Aug 1, 2019

@AndreaBarr The PR is now ready to be merged. Thanks.

@AndreaBarr AndreaBarr merged commit c2c9432 into MicrosoftDocs:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants