Add optional JSON output #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow users to select a custom reporter that prints JSON instead of `sed` commands - Opt-in by adding "reporter": "json" to the configuration file
wileykestner
requested review from
keith,
marcosgriselli and
sberrevoets
as code owners
keith
reviewed
Aug 2, 2023
Sources/unused-imports/main.swift
Outdated
| if string == "json" { | ||
| self.reporter = JSONReporter() | ||
| } else { | ||
| self.reporter = nil |
There was a problem hiding this comment.
can we make this case error for unhandled values?
There was a problem hiding this comment.
Absolutely. Great suggestion.
Sources/unused-imports/main.swift
Outdated
| self.reporter = nil | ||
| } | ||
| } else { | ||
| self.reporter = nil |
There was a problem hiding this comment.
Suggested change
| self.reporter = nil | |
| self.reporter = SedCommandReporter() |
seems fine to default this here so you can eliminate the optionality
There was a problem hiding this comment.
Absolutely. 100%.
keith
approved these changes
Aug 3, 2023
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to select a custom reporter that prints JSON instead of
sedcommandsOpt-in by adding
"reporter": "json"to the configuration file