Skip to content

Conversation

huoxiaoyao
Copy link

Description

Adds

  • an interference module in order to easily generate interference in the time or frequency domain
  • a simple covariance estimator to estimate such interference from masked pilot symbols
  • a rayleigh channel with multiple taps
  • some convienience functions
  • Fixes a bug?

No

  • Adds a new feature?

See description above

  • Introduces API changes?

No

  • Other contributions

I have implemented the changes you suggested from the first review. The code does not yet contain a tutorial notebook - this is something we could add if you decide to use (part of) this PR.

Checklist

  • Detailed description
  • Added references to issues and discussions
  • Added / modified documentation as needed
  • Added / modified unit tests as needed
  • Passes all tests
  • Lint the code
  • Performed a self review
  • Ensure you Signed-off the commits. Required to accept contributions!
  • Co-authored with someone? Add Co-authored-by: user@domain and ensure they signed off their commits too.

@jhoydis jhoydis self-assigned this Aug 8, 2024
@jhoydis
Copy link
Collaborator

jhoydis commented Aug 8, 2024

Hi @huoxiaoyao,

Thanks for this PR. We'll review it and come back to you. This might take a bit of time though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants