Remove quartz and joda-time dependency from maestro common #110
+189
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused quartz and joda‑time dependencies from maestro common and updates various dependency versions while refactoring related code to use java.time.
- Removed quartz and joda‑time dependencies in build scripts
- Updated dependency versions in gradle.lockfile and dependencies.gradle
- Refactored timezone and cron validation logic to use java.time and newer cron-utils APIs
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| maestro-server/gradle.lockfile | Updated dependency versions and removed quartz/joda‑time references |
| maestro-common/* | Updated tests and validations to use java.time and new cron-utils APIs |
| maestro-common/utils/TriggerHelper.java | Refactored cron parsing and execution time calculation |
| maestro-common/build.gradle | Removed quartz and joda‑time dependency declarations |
| maestro-aws/gradle.lockfile | Updated AWS dependency versions |
| dependencies.gradle | Updated cron-utils version; joda‑time dependency definition remains |
Comments suppressed due to low confidence (2)
dependencies.gradle:13
- Since the joda‑time dependency has been removed from maestro common, consider also removing its definition here to keep the dependencies file clean.
jodaTimeDep = 'joda-time:joda-time:2.10.+'
maestro-common/src/test/java/com/netflix/maestro/validations/TimeZoneConstraintTest.java:54
- [nitpick] Consider renaming the test method to something more descriptive (e.g., testEmptyTimezone) to clearly indicate the scenario being tested.
public void isEmpty() {
| DateTimeZone.forID(timezone); | ||
| } catch (IllegalArgumentException e) { | ||
| ZoneId.of(timezone); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Consider catching a more specific exception (e.g., DateTimeException) instead of Exception to avoid masking unrelated errors.
Suggested change
| } catch (Exception e) { | |
| } catch (DateTimeException e) { |
Copilot uses AI. Check for mistakes.
This was referenced Jun 1, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew build --write-locksto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Remove quartz and joda-time dependency from maestro common.