Remove Legacy VS Options UI: WinForms & WPF View, Models, and Resources

[donnie-msft]

Bug

Fixes: Decommission Legacy VS Options NuGet Settings · Issue #14398 · NuGet/Home
Fixes: Remove copied WatermarkedTextbox styles once keys are available from VS Platform · Issue #12163 · NuGet/Home

Description

Given the following pages have been onboarded to Unified Settings:

• Onboard NuGet to Unified Settings and create General page #6229
• Onboard Configuration Files page to Unified Settings #6393
• Onboard Package Sources page to Unified Settings #6496
• Onboard Package Source Mapping page to Unified Settings #6523

By my calculations, the onboarding to Unified Settings has let me remove a net of 2,981 lines of src/ code (ignoring tests) from the NuGet.Client repo. The onboarding PRs added 2,631 lines of src/ code, and this PR removes 5,612 src/ lines.

This PR removes UI and supporting assets such as:

• All VS Options WinForms UI, controls and implementation
  • Remove <UseWinForms>true</UseWinForms> from NuGet.PackageManagement.UI.csproj
• All VS Options WPF UI, controls and implementation (Models and some ViewModels).
• No longer needed supporting controls like CheckedListBoxAccessibleObject for accessibility support
• OptionsPageBase class.
• StubGeneralOptionControl and accompanying .pkgdef declaration which was used when both USX & Legacy options were in place.
• Resource strings which are either moved to the project hosting USX, or the strings are no longer relevant (eg, USX manages the Add/Remove buttons and accompanying strings).
• The folder which is now empty: src/NuGet.Clients/NuGet.PackageManagement.UI/Options

Refactoring

• Menu commands will now use NuGet's OptionsPageActivator for menu command handling.

  • For example, Tools -> NuGet Package Manager -> NuGet Package Manager Settings and Package Manager Console's settings icon button.

  • Commented about the relationship between the legacy page GUIDs between USX's registration.json and NuGet's OptionsPageActivator.

PR Checklist

• Meaningful title, helpful description and a linked NuGet/Home issue
• Added tests
• Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. Update docs with VS Options pages with Unified Settings Home#14039

[nkolev92]

These guids are pretty wild, and so freaking hard to follow, so thanks for the pointers.

But this is mostly code removal so reviewing was doable after I filtered out the removed files.

[donnie-msft]

Merging this PR is blocked on failures in the Client CI pipeline that are unrelated to this change. Andy is working on a fix, see #6534

[donnie-msft]

The blocking PR just merged, so will rebase this PR now.