Fix UIActionEngine test flakiness #6538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donnie-msft
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
Thanks for improving this!
Do you know if the event status is now something besides Cancelled after this change? I had to remove a bunch of assertions due to that in https://github.com/NuGet/Client.Engineering/issues/2798.
test/NuGet.Clients.Tests/NuGet.PackageManagement.UI.Test/Actions/UIActionEngineTests.cs
Show resolved
Hide resolved
dtivel
approved these changes
Jul 8, 2025
nkolev92
force-pushed
the
dev-nkolev92-fixUIActionEngineTestFlakiness
branch
from
5294f03 to
d7b414f
Compare
donnie-msft
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14402
Fixes: https://github.com/NuGet/Client.Engineering/issues/2798
Description
Follow up to a discussion with @donnie-msft and his PR #6535.
The root cause is that we're calling the telemetry service static. This PR moves away from that in a similar fashion like #6419 and #6417
PR Checklist