Simplify certificate validation logic while raising NU3043 error in dotnet.exe #6553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove assembly version check when validating certificate fingerprints. Now, an ArgumentException is thrown if the fingerprint is invalid or if the hash algorithm is SHA1, regardless of assembly version. Eliminate logging of warnings for SHA1 when assembly version is less than 10.
Introduce a new test method `DotnetSign_SignPackageWithInsecureCertificateFingerprint_ThrowsExceptionAsync` in `DotnetSignTests.cs`. This test ensures that signing a package with an insecure SHA1 certificate fingerprint throws an exception. It is configured to run on Windows and Linux platforms only.
Changed RunDotnet method in DotnetIntegrationTestFixture.cs from private to internal for broader access. Updated DotnetSignTests.cs to check AllOutput for error codes instead of just Errors, enhancing test validation. Introduced expectSuccess variable to handle different outcomes based on hash algorithm, improving test flexibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Tracking: NuGet/Home#13814
Description
When we merged #6171 PR, we added custom logic to get different behavior if the version of .NET SDK is 10 or not. In .NET 10 we wanted NU3043 to be raised as an error whereas in previous versions we wanted it to be a warning.
Removed assembly version check when validating certificate fingerprints in this PR because we are only inserting into .NET 10 now. Now, an ArgumentException is thrown if the fingerprint is invalid or if the hash algorithm is SHA1, regardless of assembly version. Eliminate logging of warnings for SHA1 when assembly version is less than 10.
PR Checklist
[ ] Added tests- No functional changes[ ] Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.