Correction of Extended Tofts model #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed signals acquired with oversampled center of k-space (radial, spira, PROPELLER trajectories)
|
Hi - I was wondering if you checked compatibility of the licenses? The overarching package is Apache 2.0 and this added functionality is GPL, which I believe is more restrictive? I'm not sure that would work but I may get this wrong.. |
|
Thanks for the tip! I removed GPL:) |
|
Hi, I haven't heard anything since August, what is the status? I would like to refer to OSIPI in our manuscript which would require a merge. |
|
Hello, Sorry - I thought this had been merged. This is a bit unusual - the code collection was just meant to bring code together for us to use for making the osipi package. I see no reason why an extra folder can't be added with this extra functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a correction for the Extended Tofts model accounting for time-averaged signals acquired with an oversampled center of k-space (radial, spiral, PROPELLER trajectories). An article describing the correction will published soon.