Skip to content

Conversation

Aditi574
Copy link
Contributor

Fixed #40

Fixes issue: #40

Changes:

  • sorted search keys
  • print search results in sorted order

image

@Aditi574
Copy link
Contributor Author

@AdiChat please review this!

@AdiChat
Copy link
Member

AdiChat commented Feb 25, 2018

Looks great 😍

Hope you are enjoying your journey 🚆 with OpenGenus

@AdiChat AdiChat merged commit 7714198 into OpenGenus:master Feb 25, 2018
@AnkitaKhurana
Copy link
Member

AnkitaKhurana commented Feb 26, 2018

Hi @Aditi574
I was working on the new merged code which should show sorted results.
Here is what I have found.

image
"Bogo Sort"

image
"C Topic"

I have just attached 2 Screenshots
You can try the query 'graph' and you will find 'Adjacency Lists In C' down somewhere in the end even if it starts with 'A'.

I am not sure if the results are sorting as expected. i.e. Alphabetically
@AdiChat correct me if I am wrong.
If I have misunderstood the feature.

@AasthaGupta
Copy link
Contributor

AasthaGupta commented Feb 26, 2018

@AnkitaKhurana Thank you for pointing this out.
The reason for some of the results not getting sorted was that we were sorting results on the basis of 'keys' but keys also contain multiple other search queries.

@AdiChat I have fixed it here #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display Results of Offline Search in Alphabetical Order

4 participants