Update Java wrapper API to support frame modes #257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
P.S. being somewhat new to Github, I wasn't sure how to squash the (minor) change to the Python CMakeLists; accept or ignore that change if you will. All it does is fix a compilation error from omitting the Python libraries during linking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes Java wrapper API to use frame modes throughout, but retains the existing method of setting the frame mode using setVideoFormat and setDepthFormat. DepthFormat and VideoFormat are made into simple enums with no height, width or format data; that information is now stored on the FrameMode object.
The one backwards-incompatible change here is the change to the DepthHandler and VideoHandler classes to make them take FrameMode objects instead of DepthFormat/VideoFormat objects. This is necessary because this change unifies the frame format information under FrameMode.