Transparently enabling setting kinect resolution with Sync C wrapper #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 30, 2012 00:35
…ugh c_sync wrapper
…ons (under original names) that maintain backwards compatibilty, and functionality
Author
|
So the last commit brought back backward compatibility. So now we have the benefit of the extra functionality, with none of the hindrance of having to bring old code up to date. |
Member
|
Sweet! I'm actually planning to (gently) break API with the removal of freenect_select_subdevices in libfreenect-0.2 when I change how devices are enumerated and opened to add support for the Kinect for Windows and the Asus Xtion cameras, so it might even be all right to break API some more then, if it means the API is more consistent. To merge your changes, though, I'll need you to sign off on your work - http://openkinect.org/wiki/Contributing_Code#Sign_your_work |
Author
|
Signed branch: #301 |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the ability to allow the user to specify resolution for the kinect, through the Sync C wrapper.
It
breaksno longer breaks the main functions' backward compatibility~~, due to changing the parameters in the list, but in such a nice way, a nice regular expression could fix it easily~~.Two of the examples used this wrapper, so I updated those two.