This repository was archived by the owner on May 17, 2023. It is now read-only.
Reduce bundle size by using "one-by-one" lodash import #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FeralAI
added a commit
to FeralAI/WebConfigurator
that referenced
this pull request
Apr 22, 2023
arntsonl
approved these changes
Apr 27, 2023
Contributor
arntsonl
left a comment
arntsonl
left a comment
There was a problem hiding this comment.
Nice, thank you for the clean-up! That's a fantastic reduction in size for a simple change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining the great GP2040-CE project, doing my first build and came across this lovely project <3
Saw an opportunity to specifically help out in this part of the code, hope that is ok!
Importing specific lodash methods individually drastically reduces the bundle as it wont include the entire lodash library.
Result from running
npm run buildBefore
After
Only tested this by running
npm run devas i don't have access to a device yet. Please verify!