Utility to get an Office compatible hash of a password #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests did not properly tests that both adapters had the exact same behavior for returned values. By using common code for testing we can assert that the behavior is now in fact identical. Also phpdocs were moved to the interface itself instead of each adapters.
…into add_password_hash
|
@Progi1984 what do you think? Did you manage to integrate this in PhpSpreadsheet or is it not reusable? I'd like to add this feature in the next PhpWord version and I need to know if I should implement it in PhpWord or use the common lib. |
|
@troosan For the integration in PhpSpreasheet, I think you should ask to @PowerKiKi . In my case, If I can, I will integrate it in PhpPresentation :) |
|
I don't have immediate plan to integrate that in PhpSpreadsheet, but that doesn't change much. I think it would have its place in Common. |
Progi1984
requested changes
May 23, 2018
| @@ -0,0 +1,224 @@ | |||
| <?php | |||
| /** | |||
| * This file is part of PHPWord - A pure PHP library for reading and writing | |||
There was a problem hiding this comment.
@troosan May be changing the part of ? :)
| /** | ||
| * Test that the encoder falls back on SHA-1 if a non supported algorithm is given | ||
| */ | ||
| public function testDafaultsToSha1IfUnsupportedAlgorithm() |
Progi1984
approved these changes
May 24, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation based on https://blogs.msdn.microsoft.com/vsod/2010/04/05/how-to-set-the-editing-restrictions-in-word-using-open-xml-sdk-2-0
done by @mariahaubner in PHPWord, but I thought this would be the correct place to put it.