Drawing : Fixed emuToPixels (returns float and not int)

[Progi1984]

No description provided.

[Brenneisen]

@Progi1984 After this update, we are getting errors in a PowerPoint file that was created and needs to be repaired when opened. Do you have any idea why this is happening? Thank you!

[Progi1984]

@Brenneisen The fix is on the way : PHPOffice/PHPPresentation#856. Sorry for problems.

[Scheissy]

hey @Progi1984!

I investigted the issue today and could fix it by changing a default value in the TextStyle constructor. In Line 55 the setIndent is called with -324900 / 9525. One line below the setMarginLeft is called with 342900 / 9525. If I change the value in setIndent to -342900 / 9525 I can open the created presentation without any issues.

[Progi1984]

@Scheissy It's a BC Break on next version. Line Width will be in pixels, not in points. It's documented. 👍

[Scheissy]

@Progi1984 I don't understand what the issue has to do with line width. I'm talking about this line. when you compare this line with the next line you can see that there might be a typo in the denominator: 324900 vs 342900.
If I use 342900 in both cases I don't get any issues.

[Progi1984]

@Scheissy Fixed : PHPOffice/PHPPresentation#857

[Brenneisen]

Hi @Progi1984 can you already estimate when there will be a new release with these fixes?

[Brenneisen]

@Progi1984 Could you please make a release? It's great if the bugs are fixed, but this way we are forced to switch to "phpoffice/phppresentation": "dev-master" branch or use "phpoffice/common": "<1.0.5". The interval between releases is very long. Although many PRs have already been merged. Is there a reason why the next release 1.2.0 should fix so many more issues?

[PowerKiKi]

Released as https://github.com/PHPOffice/PHPPresentation/releases/tag/1.2.0