GPU compatibility check before accepting GPU as the device to be used #4499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
timminator
changed the title
There was a problem hiding this comment.
Thanks for your contribution! The logic you implemented looks mostly good to me. However, I would suggest introducing a global flag (an environment variable) to control the behavior: whether to reject an invalid device (e.g., by raising a RuntimeError/ValueError) or to fall back to the CPU. This is because in some cases—for example, during automated testing—the rejection strategy is more explicit and avoids unexpected results that the fallback strategy might cause. You can define the flag here.
timminator
force-pushed
the
gpu-compatibility-check
branch
from
4b4f41a to
6776a20
Compare
|
Thanks for the review! I've added such a flag now. By default it will fall back to the CPU but this can be disabled now by setting the new environment variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a GPU compatibility check.
If the specified device is of type "GPU" we check if such a device is actually available before accepting it as the device to be used. If a usable GPU is not available we fall back to using the CPU.
Fixes PaddlePaddle/PaddleOCR#15656