Remove deprecations from GithubIntegration and Github main class
#3362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnricoMi
changed the title
GithubIntegration and Github main class
Test Results 7 files ± 0 7 suites ±0 3m 59s ⏱️ -1s Results for commit 0677da6. ± Comparison against base commit 3ccecbb. This pull request removes 5 tests.♻️ This comment has been updated with latest results. |
- moves `auth` to the front, this is now mandatory - moves base_url behind *, this must be named now - removes deprecated arguments
- moves `auth` to the front - moves base_url behind *, this must be named now - removes deprecated arguments
- removes create_jwt and def get_installation
EnricoMi
force-pushed
the
remove-deprecations
branch
from
3434f84 to
0677da6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to
__init__ofGithubIntegrationandGithub:authto the front, this is now mandatory forGithubIntegrationbase_urlbehind*, this must be named nowChanges to
GithubIntegration:create_jwtget_installationRemove deprecated AppAuthentication class