Add support to OpenAPI script for applying schema to methods #3374
+1,342
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnricoMi
commented
Nov 14, 2025
| def method_parameter( | ||
| name: str, *, required: bool = False, merge: list[str] | None = None, docstring_prepend: str | None = None | ||
| ): | ||
| def openapi_property_decorator(fn): |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| def openapi_property_decorator(fn): | |
| def openapi_method_decorator(fn): |
EnricoMi
commented
Nov 14, 2025
| def openapi_property_decorator(fn): | ||
| return fn | ||
|
|
||
| return openapi_property_decorator |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| return openapi_property_decorator | |
| return openapi_method_decorator |
EnricoMi
commented
Nov 14, 2025
Comment on lines
+663
to
+692
| def openapi_property_decorator(fn): | ||
| return fn | ||
|
|
||
| return openapi_property_decorator |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| def openapi_property_decorator(fn): | |
| return fn | |
| return openapi_property_decorator | |
| def openapi_method_decorator(fn): | |
| return fn | |
| return openapi_method_decorator |
EnricoMi
commented
Nov 14, 2025
Comment on lines
+1855
to
+1931
| for k, v in [ | ||
| ("name", cst_to_python(name)), | ||
| ] | ||
| + [ |
Collaborator
Author
There was a problem hiding this comment.
remove positional arguments
Suggested change
| for k, v in [ | |
| ("name", cst_to_python(name)), | |
| ] | |
| + [ | |
| for k, v in [ |
EnricoMi
commented
Nov 14, 2025
|
|
||
| # decorator to annotate methods with method metadata | ||
| def method_parameter( | ||
| name: str, *, required: bool = False, merge: list[str] | None = None, docstring_prepend: str | None = None |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| name: str, *, required: bool = False, merge: list[str] | None = None, docstring_prepend: str | None = None | |
| *, name: str, required: bool = False, merge: list[str] | None = None, docstring_prepend: str | None = None |
EnricoMi
commented
Nov 14, 2025
| ] | ||
| + [ | ||
| (arg.keyword.value, cst_to_python(arg.value)) | ||
| for arg in args[1:] |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| for arg in args[1:] | |
| for arg in args |
EnricoMi
force-pushed
the
openapi-apply-methods
branch
from
343e9db to
da64e5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds applying schema to methods as a sub-command separate to apply schema to properties.
Supports