Don't pick gfx1101 on nightly and weekly runs #2024
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorde-antic
changed the title
dhernandez0
reviewed
Oct 9, 2025
| label = 'mlir && ( gfx1100 || gfx1101 )' | ||
| } | ||
| } else if (codepath == "navi4x") { | ||
| label = 'mlir && ( gfx1200 || gfx1201 )' |
There was a problem hiding this comment.
should we do the same for gfx12? and navi2?
dhernandez0
reviewed
Oct 9, 2025
| case "gfx1030": | ||
| return shouldRunFromCodepath("navi21") | ||
| case "gfx1100": | ||
| case "gfx1101": |
There was a problem hiding this comment.
does this affect PR CI as well?
umangyadav
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for the gfx1101 graphics chip from nightly and weekly Jenkins CI runs to resolve an internal issue. The change restricts automated builds to use only gfx1100 for navi3x codepath testing during scheduled runs while maintaining support for both chips in regular builds.
- Modified navi3x label selection to exclude gfx1101 for nightly/weekly runs
- Removed gfx1101 from the chip-to-codepath mapping function
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves https://github.com/ROCm/rocMLIR-internal/issues/1984
Technical Details
Remove gfx1101 from nightly and weekly.
Test Plan
Nightly and weekly.
Test Result
Submission Checklist