Fix multi-GPU lit issue by using first detected agent #2031
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| config.features, config.arch_support_mfma, config.arch_support_wmma = get_arch_features(x) | ||
| config.substitutions.append(('%features', config.features)) | ||
| if not config.arch: | ||
| if agents: |
There was a problem hiding this comment.
I know here is probably not the place to do this, but is there somewhere where we can emit a warning to the user that we are only using one of the available archs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve: https://ontrack-internal.amd.com/browse/SWDEV-559813
Technical Details
This change modifies the lit configuration to select only the first detected GPU agent when initializing config.arch.
Previously, all agents were concatenated into a single string (e.g. "gfx1201,gfx1100"), which caused issues on systems with multiple different GPUs since our tools expect a single target.