Skip to content

Conversation

@mzuenni
Copy link
Collaborator

@mzuenni mzuenni commented Oct 18, 2025

This adds the possibility to set local_time_multiplier in local config files. This might be useful if hardcoded time limits are set, but you are working on a machine which is much faster/slower than the machine used for judging.

I don't know if we really want to add such a feature though @RagnarGrootKoerkamp @mpsijm ?

Copy link
Owner

@RagnarGrootKoerkamp RagnarGrootKoerkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add some docs on that this feature exists and can be enabled via local_time_multiplier in .bapctools.yaml in the contest dir?

@RagnarGrootKoerkamp
Copy link
Owner

This just needs some docs (specifically an instruction where/how to add it to either repo or personal config), and then it's probably good to merge?

@mzuenni
Copy link
Collaborator Author

mzuenni commented Oct 28, 2025

should probably be merged after the typing thing... and may needs more input if this is really something we want?

@RagnarGrootKoerkamp
Copy link
Owner

At BAPC someone said that clang on mac has slow iostream, so they wanted to correct for that. A local language-specific multiplier would be more precise, but this could be a first approximation.

@mzuenni
Copy link
Collaborator Author

mzuenni commented Oct 29, 2025

A local language-specific multiplier would be more precise

Yes but i don't think we want that? I mean we don't allow language specific multipliers and i think that is a good.

@RagnarGrootKoerkamp
Copy link
Owner

Agreed, but then it might be nice to at least merge this PR :)

@mzuenni mzuenni force-pushed the local-time-multiplier branch from cf78265 to aab3b70 Compare October 29, 2025 21:12
@mpsijm
Copy link
Collaborator

mpsijm commented Oct 30, 2025

My 2 cents:

  • Agreed that this needs documentation, with warnings (because this could be abused as well).

  • don't know if we want this

    This feature is not in the way of people who don't use it, so I'm fine with merging. I may even use this in CI after adjusting the time limits after a system test on contest hardware, if the CI is significantly slower/faster than the contest hardware.

  • Adding language-specific local multipliers feels like a can of worms. The clang thing sounds to me like a bug that should be fixed (either by fiddling with compiler parameters, or upstream in Clang, or by switching to g++ to avoid comparing apples to pears).

@mzuenni mzuenni merged commit f7afe35 into main Nov 14, 2025
6 checks passed
@mzuenni mzuenni deleted the local-time-multiplier branch November 14, 2025 17:22
mzuenni added a commit that referenced this pull request Nov 14, 2025
* local-time-multiplier

* remove default local_time_multiplier set for tests

* adjust code

* fix style

* print time limit

* add to readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants