Fix silent elimination of fragment shaders (Issue #284) #288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a fragment shader writes only its RGB components (leaving
w
uninitialized), dead-code elimination (DCE) would drop the entire entry point without warning. The SPIR-V still compiled, but at runtime the shader was missing entirely.What changed
Post-DCE check: after the second DCE pass, we now scan all declared entry points and verify their functions still exist. Added
validate_entry_points_exist()
function that runs after the second DCE pass.Error reporting: if an entry point is gone, emit a clear error.
*out = vec4(r,g,b,a)
).Added comprehensive test cases:
issue-284-dead-fragment-good.rs
- Working fragment shader with proper output assignmentissue-284-dead-fragment-bad.rs
- Problematic fragment shader that triggers the new validationEffects
The fix provides context-aware error messages:
Future improvements
Early Detection Framework:currently disabled an early detection system that could warn about potentially problematic shaders before DCE:
This could be enhanced to provide warnings rather than errors for borderline cases