-
-
Notifications
You must be signed in to change notification settings - Fork 676
Add host-mounted font support and automatic fc-cache refresh #2274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackkenney10, please let me take some time to test the changes across supported platforms (Raspberry Pi, x86).
@jackkenney10, please don't forget to include in the description that this PR will fix #2272. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes works well for the Raspberry Pi OS Lite or Debian version. However, users who installed the balenaOS version of Anthias have minimal to no control over the fonts, if they wish to install it.
It would be better if fonts like the Noto Color Emoji will be installed automatically, while still keeping the option to add fonts to the host /usr/share/fonts
.
Nico, Thank you for your review and feedback. I did not consider the case of users on balenaOS. I will investigate which fonts should be installed automatically, implement this, and update the branch with the change. Thank you! :) |
…ontainer in tools/image_builder/utils.py to automatically install emoji font in the anthias-viewer container
…viewer container in tools/image_builder/utils.py to automatically install emoji font in the anthias-viewer container" This reverts commit fa0f2b5.
…ontainer in tools/image_builder/utils.py to automatically install emoji font in the anthias-viewer container
…ontainer in tools/image_builder/utils.py to automatically install emoji font in the anthias-viewer container
…e to a conflict with host-mounted font support. Need to find another approach.
|
Nico, I'm still working on this. I'm trying to find an approach that allows both host-mounted font support, as well as an automatic install of fonts in the viewer container during build. There is nothing new to review yet. Hopefully I can figure this out soon. |
Hi @jackkenney10, just checking in on this PR — do you have an update? We'd love to get this moving again. Let me know if there's anything I can do to help. |
Just checking in to see if there are any updates to this PR? Would be useful for me as well. |
Team, I let this one slip off my radar after I got it working on my one pi. I apologize. I'll be out of town and unable to work on this until next weekend, but I'll take another look when I'm back. |
Description
Added support for fonts installed on host OS to be mounted in the anthias-viewer container, and for the font cache to be rebuilt at container startup. Users may install additional fonts in the host OS (such as
font-noto-color-emoji
), and they will be available for use by the Webviewer in the anthias-viewer container.Syncing of fonts is achieved by mounting /usr/share/fonts to /usr/share/fonts in anthias-viewer. Rebuilding of the font cache at container startup is achieved by running
fc-cache -f -v
in entrypoint.sh, which has been made the entrypoint for the anthias-viewer container.This will address issue #2272.
I made minimal changes to the Dockerfile to support host-mounted fonts and automatic fc-cache refresh at container startup. Tested successfully on Raspberry Pi. No core application logic was changed.
Checklist