Skip to content

Conversation

@STRATZ-Ken
Copy link

This is missing tests as I was unsure which tests would really be required.

Most core functions such as CloseAsync call _pump.Post directly and should bypass these limits. Only messages sent by the user's code should be prevented from the `queue.

https://github.com/graphql-dotnet/server/blob/be01da8ebcb0634ce271d1463c677e310b596160/src/Transports.AspNetCore/WebSockets/WebSocketConnection.cs#L210

@Shane32
Copy link
Owner

Shane32 commented Sep 23, 2024

Todo:

  • Reformat per editorconfig
  • Add test to confirm that rate limit is enforced
  • Add test to confirm that rate limit is ignored for critical messages
  • Update api approvals
  • Add documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants