Change some words: master→monitor and unicorn→pitchfork #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquorning
force-pushed
the
words
branch
2 times, most recently
from
206a3f2 to
89fc2ad
Compare
byroot
reviewed
Mar 5, 2025
| ### Worker Processes | ||
|
|
||
| Note: the master uses a pipe to signal workers | ||
| Note: the monitor uses a pipe to signal workers |
Contributor
There was a problem hiding this comment.
Technically this is also outdated, as it is now a socketpair, but functionally that doesn't change much.
Contributor
Author
There was a problem hiding this comment.
In this PR I’d like to focus just on simple renaming, and keep other doc updates for another PR. 😅
Contributor
|
LGTM. cc @etiennebarrie (if you can merge when you get a minute) |
It seems from 5bcb768 that the master process should be renamed to the monitor process.
Contributor
Author
|
I squashed all master → monitor changes together into the first commit and force-pushed. Sorry for any reviewer inconvenience that may have caused. |
etiennebarrie
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading https://byroot.github.io/ruby/performance/2025/03/04/the-pitchfork-story.html, I noticed this sentence:
I had always been a bit confused by the code and documents using both “master” and “monitor” terms, and honestly thought they meant two different things.
Now, in this PR, the first commit changes docs and comments to always use “monitor”.
The 2nd commit changes (almost) all mentions of “Unicorn” into “Pitchfork” – but of course not when mentioning Pitchfork’s history, etc.
There’s still some mentions of “master”, e.g.Added into the first commit.HttpServer#master_sleep,HttpServer#awaken_master,Worker#register_to_master, and a@master_pidivar. I’m happy to change these too, if they are not deemed breaking changes. (TheHttpServermethods are private, so they should be safe to change).