Fix default for setpgid
#162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Shopify#148 I added `setpgid` as a configuration option and noted that the [default value is true](https://github.com/Shopify/pitchfork/pull/148/files#diff-58f184d7415a8c22e56e4908527cfd1c7c28ea1c5720cf4280b2d511b25f7409R181) when I [actually set it to false](https://github.com/Shopify/pitchfork/pull/148/files#diff-c548fe87144e0b662fbdfa224a8e2fc458da80bb2bc04bdcddcff77d6afc5cfcR82). That's due to the fact that I [didn't change the default kwarg value of setpgid in clean_fork](https://github.com/Shopify/pitchfork/blob/a68238217379fb283561f812b66fc06c8cdd8697/lib/pitchfork.rb#L139). That said, we are now explicitly passing the configuration value of `setpgid` to `clean_fork` so the default value of the kwarg is unused unless someone is calling it manually. Perhaps it would make sense to remove the default so that if someone is calling `clean_fork` manually then they have to be explicit about the behavior that they want. I don't know who would be doing that though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #148 I added
setpgidas a configuration option and noted that the default value is true when I actually set it to false.That's partially due to the fact that I didn't change the default kwarg value of setpgid in clean_fork. That said, we are now explicitly passing the configuration value of
setpgidtoclean_forkso the default value of the kwarg is unused unless someone is calling it manually.Perhaps it would make sense to remove the default so that if someone is calling
clean_forkmanually then they have to be explicit about the behavior that they want. I don't know who would be doing that though.