Issue/38 #39
Merged
Issue/38 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change converts the current openscad_builtins dict to real python classes. This will allow python editors to autosuggest arguments and helps with a future change to add docstrings for all of these types. These classes were generated by printing class_str then manually modifying the resulting python to be pep8 compliant.
This allows sphinx-build to run as long as it is in $PATH
This changes the behaviour of TestSolidPython.expand_scad_path so that it finds the scad directory by going up one directory from solid/test. This allows the tests to be run with run_all_tests.sh or tox. Previously running the tests with tox was failing due to not finding the example files.
flake8 is a tool which combines PyFlakes and pep8. This change allows it to be run against SolidPython with: tox -epep8 Currently there is an ignore for every failing rule so that the tox run passes. These can be removed as they are fixed in the code.
|
Have you had a chance to look at this yet? I just did a talk on SolidPython at KiwiPycon |
etjones
added a commit
that referenced
this pull request
Sep 8, 2015
Absolutely! Sorry to let this one sit so long. If you've got slides from the talk, I'd love to see them!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert openscad_builtins to real types, along with some other testing and doc generation related changes