Bootstrap .caret to FontAwesome icon font caret #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.caret is colored by border-color, Font Awesome caret inherits the font color
azturner
added a commit
that referenced
this pull request
Jan 14, 2014
…aret Bootstrap .caret to FontAwesome icon font caret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per my conversations with @edmistj, we want to switch from Bootstraps default .caret to the FontAwesome .fa-caret-down
Bootstrap's version uses borders to make it's triangle shape — so you have to set border-color to get it to match the surrounding text.
Font Awesome's version is just an icon font, so it will automatically inherit text color, making everything much simpler.