Skip to content

Conversation

@briankalwat
Copy link
Contributor

@briankalwat briankalwat commented Mar 31, 2020

Proposed Changes

This change simply surfaces the value and date of the previous metric value to the lava of the liquid dashboard widget, for determining comparisons.

Types of changes

What types of changes does your code introduce to Rock?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality, which has been approved by the core team)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • This is a single-commit PR. (If not, please squash your commit and re-submit it.)
  • I verified my PR does not include whitespace/formatting changes -- because if it does it will be closed without merging.
  • I have read the Contributing to Rock doc
  • By contributing code, I agree to license my contribution under the Rock Community License Agreement
  • Unit tests pass locally with my changes
  • I have added required tests that prove my fix is effective or that my feature works
  • I have included updated language for the Rock Documentation (if appropriate)

@briankalwat briankalwat changed the title + added previous metric date and value to metrics controller for comparisons/trends Added previous metric date and value to metrics controller for comparisons/trends Apr 1, 2020
@nairdo nairdo merged commit ef49b0a into SparkDevNetwork:develop Apr 15, 2020
@briankalwat briankalwat deleted the metric-controller-comparison branch April 19, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants