Skip to content

Conversation

@Jon-Corey
Copy link
Contributor

@Jon-Corey Jon-Corey commented Apr 4, 2024

Proposed Changes

Fixes a bug in the Registration Template Detail that caused incomplete attributes to be added to the attribute cache. These incomplete attributes cause the Obsidian Registration Entry block to throw a null reference exception whenever it tried to load a registration template's details.

This fixes that issue by removing attributes with an ID of 0 from the attribute cache right after they are added to the cache.

Fixes: #5823

Types of changes

What types of changes does your code introduce to Rock?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality, which has been approved by the core team)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • This is a single-commit PR. (If not, please squash your commit and re-submit it.)
  • I verified my PR does not include whitespace/formatting changes -- because if it does it will be closed without merging.
  • I have read the Contributing to Rock doc
  • By contributing code, I agree to license my contribution under the Rock Community License Agreement
  • Unit tests pass locally with my changes
  • I have added any required unit tests or integration tests that prove my fix is effective or that my feature works
  • I have included updated language for the Rock Documentation (if appropriate)

Further comments

Documentation

Migrations

…egistration attributes would break registrations (Fixes: SparkDevNetwork#5823)
@Jon-Corey
Copy link
Contributor Author

Closing as no longer needed since this issue was fixed in 91caab3

@Jon-Corey Jon-Corey closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copying a Registration Template Can Break All Registrations

1 participant