HubSpot Integration - Fixed HubSpot Contact Property Names #6025
+283,352
−591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b747fa7)
See the private repo for history: https://github.com/lakepointe/Rock
Reverted unnecessary LPC changes such as whitespace changes, backup files, and changes that are no longer applicable. Also included two Spark fixes that were missing from the previous LPC Rock repo: SparkDevNetwork@33b0d32 SparkDevNetwork@c79dd36
Reverted changes to which packages are used and which package versions are used. Also added the .dll.refresh files back into GitHub.
Added all commits from the previous repo up until the time of this commit (2023-10-04) that were not already in this repo. See the private repo for history: https://github.com/lakepointe/Rock
Add LPC Customizations
Added all commits from the previous repo up until the time of this commit (2023-10-04) that were not already in this repo. See the private repo for history: https://github.com/lakepointe/Rock
Added the changes I missed from the last commit (23ca436).
Added all commits from the previous repo up until the time of this commit (2024-07-22) that were not already in this repo. See the private repo for history: https://github.com/lakepointe/Rock
Removed Reference to Coach Attribute
…uses Registrations - Added Logic to Translate Marital Statuses
This is needed in addition to updating the "Scheduled Payment End Date" and "Available Transaction Frequencies" on the new registration instance. See the Preschooler's Place documentation in Lakepointe's Rockumentation.
…4-2025 Updated Preschooler's Place Logic For 2024-2025
There is a bug in the stock code causing these shorthand comments (`//-`) to render on the page. This commit replaces the shorthand comments with the full comment tags.
…-2025 Preschoolers Place - Replaced Comment Shorthand With Full Comments
…iveSchedules Check-in Manager Roster - Added Option to Show Schedules That Aren't Active
This fixes an issue where members of scheduled serve teams couldn't be edited on the Group Roster block on the public site. This was caused because scheduled serve teams only allow a member to be in the group once, whereas in other groups the person can be in the group multiple times with different roles. The logic I edited was meant to make sure that the person was always at least in the Member role for groups that aren't scheduled. It did this by adding the member role to the list of roles to give the group member. This means that if the user selected the Member role, the Member role would be added to the list a second time by this logic. This would cause the validation logic to see two roles (even though they are the same role). Since scheduled serve team members can't have more than one role in the same group, the validation logic would throw an error. This fixes that issue by only adding the Member role to the list if the group isn't a scheduled serve team.
Leader Tools - Fixed an issue where serve team members couldn't be edited
These changes were made by @shaneLPDev but not committed. Co-Authored-By: shaneLPDev <[email protected]>
Updated "Serving Teams" section to pull all groups with requirements and to filter out archived/inactive groups and members. This was done in order to make this work better with the new consolidated serve team structure.
- Removed trailing whitespace - Changed indentation to tabs for consistency - Removed single-space indentation
- Update labels for YCC
…erNewGroupTypes Check-in Troubleshooter - New Group Types
This file is based on the MyConnectionOpportunitiesSortable lava file, but rearranged in order to fit on a sidebar without overflowing or making the info hard to read. The only differences are structure and layout. There are no logic differences.
…Cards Added My Connection Request Cards Lava File
Fixed an issue with the group locator where the map was not hidden when there were no groups to show on the map. This caused the map to be shown in whatever the previous state was. This led to groups that were filtered out being shown on the map when there were no groups found that met the filters. This fixes that issue by adding a step after the filtered data is retrieved to hide the map if there are no results.
…ngFilteredGroups Group Locator - Fixed an Issue Where Filtered Groups Were Shown on the Map
Co-authored-by: shaneLPDev <[email protected]> Co-authored-by: shaneLPDev <[email protected]> Co-authored-by: Matthew Ewing <[email protected]>
HubSpot Integration - Fixed Null Reference Exception
…n-202409231316 HubSpot Integration - Fixed Null Reference Exceptions
-rock_baptism_date -rock_first_time_life_group -rock_first_time_serving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed HubSpot Contact property names rock_baptism_date, rock_first_time_life_group, and rock_first_time_serving.