Skip to content

Conversation

@OnlyByGrace
Copy link
Contributor

@OnlyByGrace OnlyByGrace commented Dec 11, 2025

Proposed Changes

This is a bug fix for a type check that made the native fieldFilterFunctionBuilder not work.

Fixes: #

Types of changes

What types of changes does your code introduce to Rock?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality, which has been approved by the core team)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • This is a single-commit PR. (If not, please squash your commit and re-submit it.)
  • I verified my PR does not include whitespace/formatting changes -- because if it does it will be closed without merging.
  • I have read the Contributing to Rock doc
  • By contributing code, I agree to license my contribution under the Rock Community License Agreement
  • [] Unit tests pass locally with my changes
  • [] I have added any required unit tests or integration tests that prove my fix is effective or that my feature works
  • I have included updated language for the Rock Documentation (if appropriate).

@cabal95 cabal95 merged commit c66549d into SparkDevNetwork:develop Dec 11, 2025
@cabal95
Copy link
Member

cabal95 commented Dec 11, 2025

@OnlyByGrace Thanks. Apparently arrays are considered objects, which is why TypeScript didn't catch this and warn about incorrect type later in the functions.

@OnlyByGrace OnlyByGrace deleted the patch-2 branch December 11, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants