-
Notifications
You must be signed in to change notification settings - Fork 78
New 3D transform algorithm for novel view synthesis. #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting -Camera pose animation proto messages
…to cut_pow/animation_camera_pose_3d
pharmapsychotic
requested changes
Jan 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The .pyc files should not be checked in
- do_prefill can be removed and done with a new BORDER_INFILL since we're supporting for all the transform modes. whatcha think?
Made a pass at getting the new messages to match in better with existing messages. How does this look to you?
message RenderMeshParameters {
float max_mesh_edge = 1; // Mesh edges longer that this values are discarded
}
message RenderPointsParameters {
float radius = 1; // The radius (in NDC units) of each disk to be rasterized
uint32 points_per_pixel = 2; // Number of points to keep track of per pixel
}
message RenderParameters {
oneof params {
RenderMeshParameters mesh = 1;
RenderPointsParameters points = 2;
}
}
enum CameraType {
CAMERA_PERSPECTIVE = 0; // Perspective camera
CAMERA_ORTHOGRAPHIC = 1; // Orthographic camera. Well suited for isometric animations
}
message CameraParameters {
CameraType type = 1;
optional float near_plane = 2; // Nearest plane depth of a rendered frustum
optional float far_plane = 3; // Farthest plane depth of a rendered frustum
optional float fov = 4; // Camera field of view (in degrees). Must be set for CAMERA_PERSPECTIVE type.
}
message TransformCameraPose {
CameraParameters camera = 1; // camera projection settings
TransformMatrix transform = 2; // 4x4 transform matrix for the next frame
RenderParameters image_render = 3;
RenderParameters mask_render = 4;
}
…ow BORDER_PREFILL for resample operation.
Kudos, SonarCloud Quality Gate passed! |
pharmapsychotic
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each pixel + corresponding depth is being considered as a point in space. The pointcloud or mesh, composed from composition of neighboring points, is rendered to obtain the final image. Returned inpaint mask is rendered in the same fashion. Type of rendering for image and mask can differ.