project-mongo-api - Mai #499
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwenzz
reviewed
May 14, 2024
There was a problem hiding this comment.
Well done Mai! I love how you implemented try...catch block to every endpoint, this shows you really paid attention to error handling.
Yet I encountered some errors when accessing your endpoints. "/avocade-sales" leads to 500 error. Could you kindly look into that? Might be deploy error...
server.js
Outdated
| expressListEndpoints(app).map((endpoint) => ({ | ||
| method: endpoint.methods.join(", "), | ||
| path: endpoint.path, | ||
| description: "Describe what each endpoint does", // Consider adding more detailed descriptions |
There was a problem hiding this comment.
Are you going to add the description for each endpoint? Currently it shows the same thing...
| // List all sales | ||
| app.get("/avocado-sales", async (req, res) => { | ||
| try { | ||
| const sales = await AvocadoSales.find().select("-_id -__v").sort({ id: 1 }); |
There was a problem hiding this comment.
nice implement of select method!
yet this endpoint leads to error... which shows error code 500
AntonellaMorittu
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://project-mongo-api-ude1.onrender.com/