Skip to content

Conversation

@Daniel-Cortez
Copy link
Contributor

@Daniel-Cortez Daniel-Cortez commented Feb 1, 2025

Fixes various spelling mistakes scattered across the codebase. While this PR doesn't change any logic (it only touches comments), I think it still makes the code look reasonably more polished.

@DimensionWarped
Copy link
Collaborator

DimensionWarped commented Mar 5, 2025

I have mixed feelings on PRs that focus on widespread spelling checks against comments. It is nice for things to be spelled correctly for sure, but Merging PRs for this sort of thing is a good way to cause people trouble with rebases for users who just want to update their own stuff. I'd say we should hold this sort of thing for the next major version upgrade of Godot (IE Godot 5) so that if they do step on someone's toes it'll be peanuts in comparison to all of the other stuff they have to deal with.

We'll keep this open until then.

@16HeuS
Copy link

16HeuS commented Mar 10, 2025

I have mixed feelings on PRs that focus on widespread spelling checks against comments. It is nice for things to be spelled correctly for sure, but Merging PRs for this sort of thing is a good way to cause people trouble with rebases for users who just want to update their own stuff. I'd say we should hold this sort of thing for the next major version upgrade of Godot (IE Godot 5) so that if they do step on someone's toes it'll be peanuts in comparison to all of the other stuff they have to deal with.

We'll keep this open until then.

There is no plan to update to 4.4 ? Only in 5.0 ? Sorry if this is not the appropriate place to ask this

@Caverns4
Copy link
Collaborator

At this time, we're only just starting to update to 4.3. When/If a 4.4 update happens, it will take some time as 4.4 has much larger changes than 4.3

@DimensionWarped
Copy link
Collaborator

We will most likely upgrade to 4.4 eventually, specifically when that release is mature. What I'm saying is that we won't be doing spell checking type merges until we upgrade to 5.

@DimensionWarped DimensionWarped changed the title Spelling fixes in comments DO NOT MERGE UNTIL 5.0 - Spelling fixes in comments Sep 22, 2025
@DimensionWarped DimensionWarped added the Hold - Major Release Only to be merged ahead of a major release and will need to be rebased at that time. label Sep 22, 2025
@DimensionWarped DimensionWarped changed the title DO NOT MERGE UNTIL 5.0 - Spelling fixes in comments Spelling fixes in comments Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hold - Major Release Only to be merged ahead of a major release and will need to be rebased at that time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants