Add missing vines and thorns for crimson/corruption blocks sets #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crimson Blocks set was missing crimson thorns and Corruption Blocks were missing corrupt vines
|
As a user who is stuck at 1% with no blocks shown in TerraMap using the Crimson set, this would be very helpful! |
jasoncoon
approved these changes
Oct 9, 2023
|
Sorry for the delay in merging this, thanks for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally both crimson and corruption blocks sets only contained vines and not thorns, and "Corrupted Vines" block id was that of corruption thorns, so crimson and corruption blocks sets actually contained different sets of blocks.
And if crimson/corruption blocks sets were intended for searching the blocks needed to be removed in order to make the world pure, the sets were incomplete as both crimson/corruption thorns and (probably) vines all count as blocks of their respective biomes and affect the world purity, and neither set contained both vines and thorns.
The fact that corruptions blocks set was missing corrupt vines (and instead contained corruption thorns) is probably not a big issue, as crimson/corruption vines can only grow on the grass blocks of the corresponding biome. But crimson blocks set not containing crimtane thorns is actually a problem because the thorns can be located anywhere and are hard to spot, and just a few (maybe even one) thorn block is enough to render the world as being 1% crimson.