Fix parsing of post 52038 classic wotlk SMSG_ON_MONSTER_MOVE (#812)

killerwife · web-flow · commit ea551957d9be · 2024-01-22T08:31:59.000+01:00
diff --git a/WowPacketParserModule.V8_0_1_27101/Parsers/MovementHandler.cs b/WowPacketParserModule.V8_0_1_27101/Parsers/MovementHandler.cs
@@ -194,7 +194,7 @@ public static void ReadMovementMonsterSpline(Packet packet, Vector3 pos, params
         {
             PacketMonsterMove monsterMove = packet.Holder.MonsterMove;
             monsterMove.Id = packet.ReadUInt32("Id", indexes);
-            if (ClientVersion.RemovedInVersion(ClientVersionBuild.V10_2_0_52038))
+            if (ClientVersion.RemovedInVersion(ClientBranch.Retail, ClientVersionBuild.V10_2_0_52038) || ClientVersion.Branch != ClientBranch.Retail)
                 monsterMove.Destination = packet.ReadVector3("Destination", indexes);
 
             packet.ResetBitReader();

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ public static void ReadMovementMonsterSpline(Packet packet, Vector3 pos, params`
`194`	`194`	`{`
`195`	`195`	`PacketMonsterMove monsterMove = packet.Holder.MonsterMove;`
`196`	`196`	`monsterMove.Id = packet.ReadUInt32("Id", indexes);`
`197`		`- if (ClientVersion.RemovedInVersion(ClientVersionBuild.V10_2_0_52038))`
	`197`	`+ if (ClientVersion.RemovedInVersion(ClientBranch.Retail, ClientVersionBuild.V10_2_0_52038) \|\| ClientVersion.Branch != ClientBranch.Retail)`
`198`	`198`	`monsterMove.Destination = packet.ReadVector3("Destination", indexes);`
`199`	`199`
`200`	`200`	`packet.ResetBitReader();`