Skip to content

Add build 4.4.0 55262. #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Add build 4.4.0 55262. #865

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b32e279
Init.
heyitsbench Jun 28, 2024
654b9cc
I'm inept.
heyitsbench Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions WowPacketParser/Enums/ClientVersionBuild.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,7 @@ public enum ClientVersionBuild
V4_4_0_55006 = 55006, // both live and ptr
V4_4_0_55056 = 55056, // both live and ptr
V4_4_0_55141 = 55141, // both live and ptr
V4_4_0_55262 = 55262, // both live and ptr

// Battle.net - should probably not mix this but oh well
BattleNetV37165 = 37165,
Expand Down
1 change: 1 addition & 0 deletions WowPacketParser/Enums/Version/Opcodes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,6 +920,7 @@ public static ClientVersionBuild GetOpcodeDefiningBuild(ClientVersionBuild build
case ClientVersionBuild.V4_4_0_55006:
case ClientVersionBuild.V4_4_0_55056:
case ClientVersionBuild.V4_4_0_55141:
case ClientVersionBuild.V4_4_0_55262:
return ClientVersionBuild.V4_4_0_54481;
default:
return ClientVersionBuild.V3_3_5a_12340;
Expand Down
3 changes: 2 additions & 1 deletion WowPacketParser/Enums/Version/UpdateFields.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,7 +1132,8 @@ private static string GetUpdateFieldDictionaryBuildName(ClientVersionBuild build
case ClientVersionBuild.V4_4_0_55006:
case ClientVersionBuild.V4_4_0_55056:
case ClientVersionBuild.V4_4_0_55141:
{
case ClientVersionBuild.V4_4_0_55262:
{
Copy link
Contributor

@Ovahlord Ovahlord Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahem.

Copy link
Contributor Author

@heyitsbench heyitsbench Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected, my bad.

return "V4_4_0_54481";
}
default:
Expand Down
2 changes: 2 additions & 0 deletions WowPacketParser/Misc/ClientVersion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1302,6 +1302,7 @@ public static ClientVersionBuild GetVersionDefiningBuild(ClientVersionBuild buil
case ClientVersionBuild.V4_4_0_55006:
case ClientVersionBuild.V4_4_0_55056:
case ClientVersionBuild.V4_4_0_55141:
case ClientVersionBuild.V4_4_0_55262:
return ClientVersionBuild.V4_4_0_54481;
case ClientVersionBuild.BattleNetV37165:
return ClientVersionBuild.BattleNetV37165;
Expand Down Expand Up @@ -1812,6 +1813,7 @@ public static bool IsCataClientVersionBuild(ClientVersionBuild build)
case ClientVersionBuild.V4_4_0_55006:
case ClientVersionBuild.V4_4_0_55056:
case ClientVersionBuild.V4_4_0_55141:
case ClientVersionBuild.V4_4_0_55262:
return true;
default:
return false;
Expand Down