Skip to content

Load spell_go destination orientation #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2025
Merged

Load spell_go destination orientation #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WowPacketParser.Proto/PacketStructures/StructureVersion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ public class StructureVersion
* Everytime you change structures.proto, please increment this version
* so that user could know if one needs to reparse the sniff
*/
public static readonly ulong ProtobufStructureVersion = 20;
public static readonly ulong ProtobufStructureVersion = 21;
}
}
1 change: 1 addition & 0 deletions WowPacketParser.Proto/PacketStructures/structures.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ message PacketSpellData {
repeated Vec3 targetPoints = 13;
optional uint32 ammoInventoryType = 14;
optional uint32 castCount = 15;
optional float dstOrientation = 16;
}

message PacketSpellStart {
Expand Down
6 changes: 5 additions & 1 deletion WowPacketParserModule.V1_13_2_31446/Parsers/SpellHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ public static void ReadSpellTargetData(Packet packet, PacketSpellData packetSpel
}

if (hasOrient)
packet.ReadSingle("Orientation", idx);
{
var orientation = packet.ReadSingle("Orientation", idx);
if (packetSpellData != null)
packetSpellData.DstOrientation = orientation;
}

int mapID = -1;
if (hasMapID)
Expand Down
6 changes: 5 additions & 1 deletion WowPacketParserModule.V6_0_2_19033/Parsers/SpellHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,11 @@ public static void ReadSpellTargetData(Packet packet, PacketSpellData spellData,
}

if (hasOrient)
packet.ReadSingle("Orientation", idx);
{
var orientation = packet.ReadSingle("Orientation", idx);
if (spellData != null)
spellData.DstOrientation = orientation;
}

packet.ReadWoWString("Name", nameLength, idx);
}
Expand Down
6 changes: 5 additions & 1 deletion WowPacketParserModule.V7_0_3_22248/Parsers/SpellHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,11 @@ public static void ReadSpellTargetData(Packet packet, PacketSpellData packetSpel
}

if (hasOrient)
packet.ReadSingle("Orientation", idx);
{
var orientation = packet.ReadSingle("Orientation", idx);
if (packetSpellData != null)
packetSpellData.DstOrientation = orientation;
}

int mapID = -1;
if (hasMapID)
Expand Down
6 changes: 5 additions & 1 deletion WowPacketParserModule.V8_0_1_27101/Parsers/SpellHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,11 @@ public static void ReadSpellTargetData(Packet packet, PacketSpellData packetSpel
}

if (hasOrient)
packet.ReadSingle("Orientation", idx);
{
var orientation = packet.ReadSingle("Orientation", idx);
if (packetSpellData != null)
packetSpellData.DstOrientation = orientation;
}

int mapID = -1;
if (hasMapID)
Expand Down