Skip to content

Conversation

@shamage
Copy link

@shamage shamage commented Sep 5, 2025

  • Removes a type error: The original code was adding a value of type uint to a collection of type List, which led to a compiler error. The fix ensures the correct type using an explicit conversion to int.

@Shauren
Copy link
Member

Shauren commented Sep 5, 2025

which led to a compiler error

Clearly not true, the project builds fine

What does it actually fix?

@shamage
Copy link
Author

shamage commented Sep 5, 2025

which led to a compiler error

Clearly not true, the project builds fine

What does it actually fix?

The fix I made addresses a potential type incompatibility - specifically, the conversion of a uint value to an int when inserting into a List<int> collection.
Although the project currently builds without error, this change is a preventative measure to ensure that the correct type is always inserted into a List<int>. In some cases (e.g., with stricter compiler settings or when changing platforms), an error could occur if the types did not match.

@Shauren
Copy link
Member

Shauren commented Sep 5, 2025

What are you even talking about, the type of id variable is int

@shamage
Copy link
Author

shamage commented Sep 5, 2025

What are you even talking about, the type of id variable is int

Uhupps ... I overlooked that. Sorry.

@shamage shamage closed this Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants