Fix #7426: Support underscores in Vault and Consul secret reference paths #7427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7426
Description
Added underscore support to
vaultMatch
andconsulMatch
regex patterns to allow secret keys likeAPI_KEY
andDB_PASSWORD
.Before:
$secret_vault.([A-Za-z0-9\/\-\.]+)
After:
$secret_vault.([A-Za-z0-9_\/\-\.]+)
Motivation and Context
Vault references are currently truncated at underscores, forcing users to duplicate secrets with different names. This fixes the regex to match standard naming conventions used in production environments.
Example:
$secret_vault.kv-v2/path.API_KEY
.API
❌.API_KEY
✅This aligns vault/consul patterns with
envValueMatch
which already supports underscores.Breaking Change Note
Potential edge case: If anyone is currently using the underscore as an intentional path terminator (e.g.,
$secret_vault.path.API_KEY
expecting only.API
to be processed with_KEY
as a literal suffix), this will now include the full path. However, this use case is highly unlikely compared to the standard use of underscores in secret names.How This Has Been Tested
go build
Types of changes
New feature (low probability small breaking change but adds functionality) -