send_statustext_message #71
Conversation
modules/mavlink/flight_controller.py
Outdated
| Sends a STATUSTEXT message to the vehicle. | ||
| """ | ||
| message_bytes = message.encode("utf-8") | ||
| msg = vehicle.message_factory.statustext_encode(severity, message_bytes) |
There was a problem hiding this comment.
Can you check to make sure there is a target_system and target_component parameter? Please use the ones specified in the example. Also, are you able to test this? Could you write an integration test that just runs this (ie sends a bunch of messages)? You will connect to mission planner just as described in the example, and then see if you can see the messages in mission planner. (Let me know if you need help testing)
modules/mavlink/flight_controller.py
Outdated
|
|
||
| def send_statustext_msg( | ||
| self, | ||
| vehicle: dronekit.Vehicle, |
There was a problem hiding this comment.
Remove this from the function signature, you should use self.drone as the vehicle.
modules/mavlink/send_messages.py
Outdated
| controller.send_statustext_msg(controller.drone, msg, mavutil.mavlink.MAV_SEVERITY_INFO) | ||
| time.sleep(1) # Wait 1 second between messages | ||
|
|
||
| controller.drone.close() |
There was a problem hiding this comment.
Probably don't need this, since I think you're not supposed to access controller.drone outside the class.
| controller.send_statustext_msg("") | ||
| else: | ||
| print("Failed to get odometry") | ||
| controller.send_statustext_msg("Failed to get odometry") |
There was a problem hiding this comment.
Leave this as a regular print, as we would want to see on the terminal what errors we get
| controller.send_statustext_msg("alt: " + str(home.altitude)) | ||
| else: | ||
| print("Failed to get home position") | ||
| controller.send_statustext_msg("Failed to get home position") |
| controller.send_statustext_msg("Downloaded commands:") | ||
| for command in commands: | ||
| print(command) | ||
| controller.send_statustext_msg(str(command)) | ||
| else: | ||
| print("Failed to download commands.") | ||
| controller.send_statustext_msg("Failed to download commands.") |
| controller.send_statustext_msg("next waypoint alt: " + str(next_waypoint.altitude)) | ||
| else: | ||
| print("Failed to get next waypoint.") | ||
| controller.send_statustext_msg("Failed to get next waypoint.") |
| result, home = controller.get_home_position(TIMEOUT) | ||
| if not result: | ||
| print("Failed to get home position") | ||
| controller.send_statustext_msg("Failed to get home position") |
| result = controller.upload_land_command(home.latitude, home.longitude) | ||
| if not result: | ||
| print("Could not upload land command.") | ||
| controller.send_statustext_msg("Could not upload land command.") |
| success, controller = FlightController.create("tcp:localhost:5672") | ||
| if not success: | ||
| print("Failed to connect") | ||
| return 1 |
There was a problem hiding this comment.
Could you make this return -1 instead?
| Main function. | ||
| """ | ||
| # Connect to the vehicle | ||
| success, controller = FlightController.create("tcp:localhost:5672") |
There was a problem hiding this comment.
Can you make the address a global variable like in test_flight_controller.py?
|
|
||
| for msg in messages: | ||
| controller.send_statustext_msg(msg, mavutil.mavlink.MAV_SEVERITY_INFO) | ||
| time.sleep(1) # Wait 1 second between messages |
There was a problem hiding this comment.
Can you make DELAY a global variable like in test_flight_controller.py?
|
|
||
| for msg in messages: | ||
| controller.send_statustext_msg(msg, mavutil.mavlink.MAV_SEVERITY_INFO) | ||
| time.sleep(DELAY_TIME) # Wait 1 second between messages |
There was a problem hiding this comment.
You can remove the comment here
| from pymavlink import mavutil | ||
|
|
||
| from modules.mavlink.flight_controller import FlightController | ||
|
|
There was a problem hiding this comment.
Add one more space here (2 spaces to separate import from constants)
No description provided.