fixed vector_reduce_add example #2311
Open
+276
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st other examples. supports tiled computation. kernel code uses templates.
fifield
requested changes
May 14, 2025
Comment on lines
-38
to
-39
| AIE_PREPARE_FOR_PIPELINING | ||
| AIE_LOOP_MIN_ITERATION_COUNT(8) |
There was a problem hiding this comment.
This appears to revert the changes from #2248
There was a problem hiding this comment.
Are any of the changes to this file required? It appears to be reverting recent changes such as #2234?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original programming example didn't work with test.cpp from other examples. the issue apparently stemmed from distinct kernel syntax requirements associated with the older way of managing host-NPU buffers.
now works with the newer host-NPU buffer method already present in most other examples.
furthermore: supports tiled computation. kernel code uses templates.