Do not treat columns with partial unique indexes as unique in psql driver #1462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the psql driver where partial unique indexes will mark a column as unique, which is not true as it is only unique over a subset of rows. This currently leads to bugs such as #1436 where incorrect relations are generated (one-to-one instead of one-to-many) but could potentially also lead to other bugs where this difference is important.
This fix is implemented by adding a condition to the query in
*PostgresDriver.loadUniqueColumns
that excludes partial indexes by filtering on thepg_index.indpred
column which will be null if it is not a partial index as stated in the PostgreSQL docs: